-
Notifications
You must be signed in to change notification settings - Fork 10.9k
[ADD] project/milestones: using project milestones #15258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @xpl-odoo |
xpl-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @zulu-odoo !
Thanks for the PR, don't hesitate to comment if my suggestions aren't clear (or if you disagree ;))
content/applications/services/project/project_management/project_milestones.rst
Outdated
Show resolved
Hide resolved
content/applications/services/project/project_management/project_milestones.rst
Outdated
Show resolved
Hide resolved
content/applications/services/project/project_management/project_milestones.rst
Outdated
Show resolved
Hide resolved
content/applications/services/project/project_management/project_milestones.rst
Outdated
Show resolved
Hide resolved
content/applications/services/project/project_management/project_milestones.rst
Outdated
Show resolved
Hide resolved
| - :guilabel:`Sales Order Item`: this field is filled in automatically when using milestones as an | ||
| invoicing method on a sales order. | ||
| - :guilabel:`Quantity (%)`: percentage of the ordered quantity that will automatically be delivered | ||
| once the milestone is reached. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about: covering the milestones' basic configuration first (kind of like you did) and clearly separating all info/options related to "based on milestone" projects?
content/applications/services/project/project_management/project_milestones.rst
Outdated
Show resolved
Hide resolved
content/applications/services/project/project_management/project_milestones.rst
Outdated
Show resolved
Hide resolved
| - :guilabel:`Reached`: This box is automatically checked when all tasks linked to the milestone are | ||
| completed (marked as :doc:`Done or Cancelled <../tasks/task_stages_statuses>`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would specify that one should first link one or more tasks to a milestone using the Milestone field. Maybe in the "Using" section instead?
62f3869 to
c914e55
Compare
task-id: 3305827
7c7b12c to
1fd3a4d
Compare
xpl-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job and thanks for addressing my suggestion @zulu-odoo !
I fixed the commit issue yesterday by the way, so we are good to go :)
@robodoo r+

task-id: 3305827