Skip to content

Conversation

@zulu-odoo
Copy link
Contributor

task-id: 3305827

@robodoo
Copy link
Collaborator

robodoo commented Nov 13, 2025

Pull request status dashboard

@zulu-odoo zulu-odoo requested a review from a team November 13, 2025 14:03
@zulu-odoo
Copy link
Contributor Author

Hi @xpl-odoo
Could you take a look at this new doc whenever possible? It's not an urgent one ;)
Thank you!

@C3POdoo C3POdoo requested a review from a team November 13, 2025 14:28
@zulu-odoo zulu-odoo removed the request for review from a team November 17, 2025 07:37
@xpl-odoo xpl-odoo requested review from xpl-odoo and removed request for a team November 17, 2025 10:09
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @zulu-odoo !
Thanks for the PR, don't hesitate to comment if my suggestions aren't clear (or if you disagree ;))

Comment on lines 36 to 39
- :guilabel:`Sales Order Item`: this field is filled in automatically when using milestones as an
invoicing method on a sales order.
- :guilabel:`Quantity (%)`: percentage of the ordered quantity that will automatically be delivered
once the milestone is reached.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about: covering the milestones' basic configuration first (kind of like you did) and clearly separating all info/options related to "based on milestone" projects?

Comment on lines 42 to 43
- :guilabel:`Reached`: This box is automatically checked when all tasks linked to the milestone are
completed (marked as :doc:`Done or Cancelled <../tasks/task_stages_statuses>`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would specify that one should first link one or more tasks to a milestone using the Milestone field. Maybe in the "Using" section instead?

@zulu-odoo zulu-odoo force-pushed the 19.0-milestones-zulu branch from 62f3869 to c914e55 Compare November 25, 2025 13:58
@xpl-odoo xpl-odoo force-pushed the 19.0-milestones-zulu branch from 7c7b12c to 1fd3a4d Compare November 25, 2025 15:36
Copy link
Contributor

@xpl-odoo xpl-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job and thanks for addressing my suggestion @zulu-odoo !
I fixed the commit issue yesterday by the way, so we are good to go :)
@robodoo r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants